Base Apparel website made with HTML, CSS AND JAVASCRIPT
Design comparison
Solution retrospective
Any feedback would be appreciated, and i can't get around the email validation.
Community feedback
- @stefani-josifovskaPosted over 2 years ago
I really love the design and I think you've done an amazing job CSS-wise (note that I'm only seeing the mobile version at the moment)! Regarding the email validation, judging from the code, I would say that the problem lies in the fact that you have commented out the listener which listen for your event, so there really isn't any way to make the browser go through the js file one again, meaning once it's loaded and you start typing, the input won't match the email pattern, of course, and it throws the error message. Also, I see you've used the .preventDefault() method, but unfortunately there isn't an event to attach it to, so that's why it's not working. So I guess you could try calling validation(e) inside the listener definition, so right next to "submit", and maybe pulling the const definitions outside of the function. And I don't reallt understand the purpose of the email===" " condition inside the if-statement, but if you define this with a && operator, the if-statement would never be true, therefore you will forever be stuck with the error message. Sorry for the quite long comment but I hope I've managed to help a little bit :)
Marked as helpful1@Deevyn9Posted over 2 years ago@stefani-josifovska Thanks for your comment, don't worry about the length of the comment, it was a good read... I'll look into fixing the errors.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord