Base Apparel Webpage

Community feedback

• 

  ronaldlamdev•430

  @ronaldlamdevPosted over 2 years ago

  I would set the overflow of the body to hidden so that it removes the little white space underneath the hero image when in desktop view. => body { overflow: hidden; }

  Marked as helpful

  0
• 

  P

  Jason Nembhard•320

  @jNembhardPosted over 2 years ago

  Great attempt Andrew! If you want to display the image properly, one strategy would be to wrap the form content and picture in it's own container, and then wrap both those containers in a wrapper and put a flex property on the "master container." Set the picture container to have a min-width of the full size of the picture and then make the picture responsive: (width: 100% height: auto) and it will fill that space. you also want to set a property called aspect-ratio directly on the picture with css code that mirrors the width and height of the picture. This will prevent cumulative layout shift (CLS) while the picture is loading and also keep your lighthouse performance scores nice and high. Hope this helps.

  Marked as helpful

  0