Skip to content
Submitted about 1 year ago

Base Apparel - Solution using HTML, CSS Grid and JavaScript

Lucas Sauham•30
@LucasSauham
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Base Apparel coming soon page
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I started using FlexBox and CSS Grid recently. I want to improve on some points:

1 - The divs are changing position when clicking on the check email button 2 - I managed to put the TextField and the button together, however, the button is resizing as the error symbol appears. Also, when "opacity" is applied, it shows the border of the div.

I accept suggestions, thank you!

Community feedback

  • Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted about 1 year ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    COMPONENT MEASUREMENTS 📐:

    • Use min-height: 100vh for div class="grid-container" instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens, such as mobile devices in landscape orientation.
    • For example; if we set height: 100vh then the div will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.
    • But if we set min-height: 100vh then the div will start at 100vh, if the content pushes the div beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    Marked as helpful
    0
    Lucas Sauham•30
    @LucasSauhamPosted about 1 year ago

    Thanks for suggestions,@0xAbdulKhalid

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord