Base Apparel Sollution Using SCSS , JS & CSS-GRID

Community feedback

• 

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  It looks really good this is not a easy challenges with the faint colored backgrounds. In the screenshot comparison you can see you left off a lineal gradient but I think it looks better without it but that is the main difference with your vs the finished

  In terms of the Email Validation since you added in your own you can just make your email input a TYPE regular text input and that will get ride of the default browser validation cause you do not really want it to pop up at the same time your invalid message pops up

  1

  ---

  

  Alif2001•70

  @Rafi8811Posted over 3 years ago

  @palgramming changed it to text , thanks for the tip

  0
• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Alif2001! 👋

  Well done on this challenge! Here's a few things I'd suggest you to take a look at:

  • I can submit your form even if my inputed email is incorrect. This is because you don't use event.preventDefault() method on your Form. This method tells the user agent that if the event does not get explicitly handled, its default action should not be taken as it normally would be.
  • Change the alt attributes for the .logo image, as it doesn't add any extra context for screen reader users. Since your image is decorative your alt text should be provided empty (alt="") so that they can be ignored by assistive technologies.

  Keep up the good work! 💪

  0