Base apparel landing page using HTML, CSS and JS

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Greetings, Lucas! 👋

  Good effort on this challenge! 👍

  Yeah, I do sometimes feel confused by the MDN documentation (good to know that I am not the only one who feels it 😆). There are a lot of text and links which makes it looks complicated to me. 😅

  Anyway, some suggestions from me.

  • I am not sure about the ARIA attributes. I did things differently. So, I would have an aria-describedby attribute on the input element. After that, I had an aria-live on the error message element. This way, once the error message is visible then the screenreader can also announce the error message. You can see my solution to understand what I did.
  • For the responsiveness of the site, on 1000px width, the input element and the image are very wide. So, I would recommend having a container element to limit the width of all elements. I recommend setting a max-width and margin: 0 auto to center the elements horizontally.

  That's it! Hope this helps. 😊

  Marked as helpful

  1