Base Apparel - HTML/CSS

Community feedback

• 

  Tiffany Arellano•205

  @yiranoPosted about 5 years ago

  Hi Viet!

  I'm so happy I looked at your code because I couldn't figure out what that second linear-gradient was used for. I also like how the height of your image responds smoothly in responsive so I will have to hack your code and figure out how you did that as well.

  I would try wrapping the email input and the email button to use absolute positioning on the button though. Negative margins are a little "hacky" in my opinion.

  1

  ---

  

  Tiffany Arellano•205

  @yiranoPosted about 5 years ago

  @ThePVH You're welcome! If you could take a look at some of my projects and critique mine I'd appreciate it also! I'm really liking your work flow. :)

  0

  

  Viet Hung Pham•180

  @ThePVHPosted about 5 years ago

  Hi @yirano ! Thanks for your feedback. Wow I couldnt think of wrapping the input like that. I will give it a try.

  Thanks a lot.

  0
• 

  argel omnes•1,800

  @argelomnesPosted about 5 years ago

  Hey Viet,

  This looks good! My only thought is to consider making the input wider on mobile.

  1

  ---

  

  Viet Hung Pham•180

  @ThePVHPosted about 5 years ago

  Hi @argelomnes, Thanks for your feedback. I really appreciate it.

  0
• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 5 years ago

  Great work Viet and congrats on submitting your first solution! Your landing page looks really good 👍

  I noticed you're using the img element for the mobile image and then a background-image for the desktop image. I'd recommend you take a look at the picture element as it allows you to conditionally add/remove images within the same element. It's a really useful element!

  Keep up the great work!

  0

  ---

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 5 years ago

  @ThePVH you're welcome!

  0

  

  Viet Hung Pham•180

  @ThePVHPosted about 5 years ago

  Hi @mattstuddert!

  I will take a look at that for sure. Thanks for your feedback.

  0