Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Base Apparel

@rStrzelczyk98

Desktop design screenshot for the Base Apparel coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


  • mobile-first workflow 📱
  • email validation on input ✔️

I would greatly appreciate any feedback 🚀

Community feedback

Vanza Setia 27,795

@vanzasetia

Posted

Hello, Robert Strzelczyk! 👋

For the email validation, <p> element for the error message should be available on the HTML, not generated through JavaScript. Also, the paragraph should have an aria-live attribute so that the error message gets announced as soon as the paragraph gets populated with the text content.

Then, the paragraph element should not have aria-label attribute since there is already visible text.

Also, the alternative text of the logo should only be the company name, "Base Apparel". Remove the "brand logo" phrases.

I hope this helps. Happy coding! 😄

Marked as helpful

0

@rStrzelczyk98

Posted

Hi!

Thanks for your feedback. I have applied your suggestions to my solution. 👍

0
Vanza Setia 27,795

@vanzasetia

Posted

@rStrzelczyk98

Great! 👏

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord