Design comparison
Solution retrospective
- mobile-first workflow 📱
- email validation on input ✔️
I would greatly appreciate any feedback 🚀
Community feedback
- @vanzasetiaPosted over 1 year ago
Hello, Robert Strzelczyk! 👋
For the email validation,
<p>
element for the error message should be available on the HTML, not generated through JavaScript. Also, the paragraph should have anaria-live
attribute so that the error message gets announced as soon as the paragraph gets populated with the text content.Then, the paragraph element should not have
aria-label
attribute since there is already visible text.Also, the alternative text of the logo should only be the company name, "Base Apparel". Remove the "brand logo" phrases.
I hope this helps. Happy coding! 😄
Marked as helpful0@rStrzelczyk98Posted over 1 year agoHi!
Thanks for your feedback. I have applied your suggestions to my solution. 👍
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord