Base Apparel Comming - Usin HTML, Sass (Flexbox & Grid), JS

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hello there, Kevin Morales! 👋

  Good effort on this challenge! 👍 Thinking about how to make this challenge responsive for bigger screens is something that stumped me a bit, too, when I worked on my solution! 😅

  I'd like to suggest,

  • Labeling the input element in some way to identify it and improve the accessibility of the page (and clear up that error on your solution report).
  • Check the responsiveness of the page from around 1300px to 1000px (at that point, a horizontal scroll bar appears along the bottom of the screen and not all of the content of the page can be seen without scrolling left/right).

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Kevin Morales•185

  @kefer16Posted over 3 years ago

  @ApplePieGiraffe Hello, thank you very much.😊 It is an honor for me that you advise me on my challenge, as it guides me from the animations that you implemented in your solution.😃

  • The accessibility error in my HTML, I corrected, I didn't know that attribute (aria-label), so I could investigate its use.
  • As for the horizontal bar error, I modified the image container to (overflow: hidden) so that it doesn't exceed the size of the image in terms of its container (I don't think it's the effective solution, but it shows less)

  ¡Happy Coding 😁!

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  @kefer16

  Good work on the fixes, Kevin! 👍

  I actually find myself using overflow-x: hidden quite a bit here and there to get rid of any unwanted horizontal scroll bars in things I build. I just try to make sure that I take care of any point where scrolling will actually be wanted (e.g., in some cases, I want there to be vertical scrolling but no horizontal scrolling, hence overflow-x not overflow). But it's all up to the scenario and what works best! 😉

  Keep it up! 😀

  Oh, and hey, if you found these tips helpful, an upvote would be appreciated! ;)

  1