Design comparison
Solution retrospective
Hello! 👋🏼
Well, contrary to the other two challenges I completed yesterday, this one was much more challenging, not because of the content itself, but because you need to carefully plan the layout you need to place all the elements in the right position. I ended up changing it twice until I landed on the one I think works better in both desktop and mobile views (I took some liberties, although it's pretty close to the original). This is what I like about these challenges, they may seem simple, but that doesn't mean you don't need to plan ahead before coding.
Any comments on how to improve if anything are always welcome.
Community feedback
- @dusan-bPosted about 2 years ago
Hello Jose,
I like your solution, I only see flaws with your footer, when the height of the browser window becomes smaller or when viewed on smaller devices. That's because you added
height: 100vh;
to yourdiv
named container. Instead you could change it tomin-height: 100vh;
, that way it becomes flexible.Hope this helps!
1@placetenoPosted about 2 years ago@dusan-b Thanks for the tip! I didn't think about that, I'll check it out. 👍🏼
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord