Design comparison
Solution retrospective
I had difficulty with the background pattern and I took me a while to really make it responsive. I'll appreciate any feedback.
Thank you!🦾
Community feedback
- @DavidMorgadePosted about 2 years ago
Hello Emmanuel, congrats on finishing the challenge! the layout looks great for me at mobile and desktop sizes!
In your html I would probably change that first
div
tag that has the classtext-container
with asection
then inside you have yourh2
yourp
and yourform
.Also inside your form, instead of using a
button
, since you are declaring aform
you can use aninput type='submit'
wich will do the work and will be more semantically correct!As a last advice, I saw that you were hiding elements from the user depending on the size of the screen, instead of doing that, try build a general html structure that you can adapt to diferent devices using CSS media queries!
Hope my feedback helps you for future projects, good job!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord