Submitted almost 4 years ago
Base Apparel Coming Soon using Grid, JS, and SCSS
@nicole-tuznik
Design comparison
SolutionDesign
Solution retrospective
Any feedback on how I could improve my code is always appreciated! Thanks!
Community feedback
- Account deleted
Hi Nicole your solution very good Its look great and very responsive keep contributing these awesome solutions.
2 - @dpayne713Posted almost 4 years ago
Nice Job Nicole,
It looks great and the form validation seems to be fully functional.
- I'd suggest putting a small amount of
padding-right
on the.text
div so that when screens get smaller the text isn't right up against the photo. - I'd also recommend starting to look into BEM naming for your classes. It helps a lot with SCSS nesting when you get deeper into large projects. http://getbem.com/naming/
Keep it up!
David
1@nicole-tuznikPosted almost 4 years ago@dpayne713 thanks so much for your suggestions, it looks much better with the padding! Also I've looked into BEM naming in the past but completely forgot about it while doing this project, thanks for the reminder. I will try to be better about using it in future projects. I appreciate all your feedback!
0 - I'd suggest putting a small amount of
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord