Base Apparel Coming Soon

Community feedback

• 

  P

  Dave•5,295

  @dwhensonPosted over 3 years ago

  hi @abhijit-programmer nice work on this one 🙌 - it's looking very nice. Here's some feedback you might like to consider:

  1. Firstly, every input should have an associated label to go with it. Here's a nice article that shows why: https://css-tricks.com/html-inputs-and-labels-a-love-story/

  2. You might also want to put some margin on the bottom of the input to keep it away from the footer at small screens and a max-width to prevent it going too wide at large widths.

  3. Regarding the image, at some screen sizes, we loose the interesting parts of the image and it ends up looking a bit odd, I think if you try the background-size: cover; combined with background-position might help you here?

  Lastly, and just a small point really, you might like to think about styling the outline property as this can make the focus ring fit in with the rest of the colour schemes.

  Really nice job though and keep up the good work! 👍 Cheers 👋

  0

  ---

  

  Abhijit Paul•195

  @ethabhijitPosted over 3 years ago

  @dwhenson Thank you so much bro

  0