Base Apparel coming soon Sass | Grid | Vanilla Js email validation

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 5 years ago

  Nice work on this challenge! Here are a few pointers after taking a look at your code:

  • I'd recommend using an actual form for the email input. You've currently got an input element with an anchor tag triggering the submission event. Instead, I would go with this kind of structure, as it's more semantically in-line with the content:

  <form>
    <input type="email">
    <button>Submit</button>
  </form>
  

  Obviously, the button wouldn't necessarily have the word "submit" in it for this layout though.

  • As you don't have a label paired up with the input I'd also recommend adding an aria-label attribute to the input to make the form field accessible to screen reader users.

  I hope these pointers help. Let me know if you have any questions!

  0

  ---

  

  Cosimo Collini•145

  @cosimocolliniPosted about 5 years ago

  @mattstuddert Thank you!! Your corrections help me a lot.

  0

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 5 years ago

  @cosimocollini you're welcome! Happy to help 🙂

  0