Base Apparel Coming Soon

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Oi Paula, tudo bem? Parabéns pelo desafio!

  Eu usei grid-template-columns: 1fr 1fr; e dividiu certinho as duas colunas sem stress.

  main {
      display: grid;
      grid-template-columns: 1fr 1fr;
      grid-template-areas:
          "logo hero"
          "text hero";
      gap: 32px 10vw;
      margin-left: 12vw;
  }
  

  Eu te recomendo fortemente aquele tutorial do Kevin Powell (testiomial section) e o curso da Origamid que tinha te falado antes, simplicou demais usar grid e isso pq eu nem sei usar as propriedades mais pesadas tipo grid area e com calc.

  👋 Espero que essas dicas tenham sido úteis e continue codando!

  1
• 

  romila•3,570

  @romila2003Posted about 2 years ago

  Hi Paula,

  Congratulations 🎉 for completing this challenge, the page and form looks great and is responsive.

  1. On desktop, I noticed that there is an overflow on the x-axis and the y-axis. To prevent this, you can give it the overflow property and set it to hidden.
  2. In mobile screen, the position of the text within the input field, is centered in the middle. To position the placeholder to the left, you can add text-align: left and keep the padding.
  3. Your button is missing the type attribute which should be set to submit since this is a form.

  Overall, great attempt and wish you the best for your future projects 👍.

  0