Design comparison
Solution retrospective
So this is the first project I've done in a while. I wanted to get solid with my javascript writing before I attempted another project. I believe this one went well for me. I still need to work on the background, so if anyone has any suggestions or advice, please, I'm all ears (or eyes in this case). I had fun working with this project, and using sass from the command line was new to me. I'm pretty satisfied how this project came out.
Community feedback
- @EdwinSchPosted about 2 years ago
Hey Lawrence, congratulations on your solution. Looks good! So I noticed the picture of the lady is warping when you scale it down. This might be an issue with your (background)image settings. Always set the image-size to 'cover' if you want an image to scale in proportion. When you use 'contain' it will keep it's original proportions and thus warp when you start scaling.
Marked as helpful2@ltc870Posted about 2 years ago@EdwinSch thanks! I think since I used the photo in my html, it had that warping affect. Your statement reminded me I could use "object-fit: cover", which acts the same way as "background-size: cover", but for pictures set with the html. Thanks for the advice!
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord