Base Apparel coming soon page

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  LABELS 🔖:

  • input elements wants a label associated with it

  ---

  • A <label> is used to create a caption for a form control. The <label> can be associated with a form control either implicitly by placing the control element inside the label element, or explicitly by using the for attribute

  ---

  • Effective form labels are required to make forms accessible. The purpose of form elements such as checkboxes, radio buttons, input fields, etc, is often apparent to sighted users

  ---

  • Even if the form element is not programmatically labeled. Screen readers users require useful form labels to identify form fields, So here using aria-label="{values}" attributes for input is enough to be accessible

  ---

  • Example:

  <input class="email error" id="emailAddress" aria-label="Enter your Email Address"  placeholder="" required="">
  

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Natsuki•50

  @NatsukiCodePosted over 1 year ago

  @0xAbdulKhalid Thank you so much for your amazing comment! I'm sure I can do better next thanks to you:)

  0
• 

  Cường•885

  @docuong0912Posted over 1 year ago

  @media screen and (max-width:375px){ // your mobile responsive style }

  and btw your submit button works fine

  1

  ---

  

  Natsuki•50

  @NatsukiCodePosted over 1 year ago

  @docuong0912 Thank you for your advice! I'm working on it right now as my mobile responsive style is completely messed up ;(

  1

  

  Cường•885

  @docuong0912Posted over 1 year ago

  @NatsukiCode don't worry, you'll get used to it in no time, just an adjustment element size to fit mobile viewport, ask if there's any problem

  Marked as helpful

  1