Design comparison
Solution retrospective
Hello Frontend Mentors! This is my 5th challenge on this platform. I tried to build this using a CSS grid.
The only thing I struggled with was positioning form and their inside items, not sure if my approach is good enough or not.
If anyone would like to contribute any ideas to improve my code, I appreciate it.
Community feedback
- @ApplePieGiraffePosted over 2 years ago
Hey, Akash! 👋
Great job on this challenge! 👏 I think the form looks good! 🙌
A few things I'd like to suggest are,
- Avoiding using
px
for setting the value offont-size
in your styles. Instead, use a responsive unit such asem
orrem
so that users will be able to change the size of the text in your site by changing the default font-size of their browser. It might also be worth setting the values for other properties such asmargin
orpadding
in those units so that your entire site will scale with the user's chosen default font-size. If you'd like to learn more about those units in CSS and how all of this works, check out this helpful video on the topic. - Avoid using ID's to style things in your CSS, as that is generally discouraged because of the high specificity of ID's (which can make overriding or inheriting styles difficult in large projects). If you’d like to learn more about CSS specificity, check out this helpful video on the topic.
Hope you find these suggestions helpful. 😊
Keep coding (and happy coding, too)! 😁
Marked as helpful1 - Avoiding using
- @kareynjeriPosted over 2 years ago
I have viewed the site form my mobile and looks great . I wish there was more to keep scrolling but i understand its predesigned challege
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord