Base Apparel coming soon page solution

Community feedback

• 

  Petrit Nuredini•2,860

  @petritnurediniPosted 10 months ago

  Congratulations on completing your Base Apparel coming soon page! It's wonderful to see your hard work and creativity come to life. Here are a few best practices recommendations to enhance your project:

  1. HTML Structure and Semantic Tags: Consider using more semantic HTML tags for better readability and SEO. For example, the <main> tag is excellent, but you could use <header> for the top section containing the logo and <article> or <section> for each content section.

  2. CSS Syntax Errors: There are small syntax errors in your CSS. For instance, in section:nth-child(1) img, you've written margine: 0,auto;. It should be margin: 0 auto;. Always ensure your CSS syntax is correct for proper styling.

  3. Responsive Images: You're using separate images for mobile and desktop, which is good. However, consider using the <picture> element with <source> to manage different image resources more effectively based on the viewport. This approach is more efficient and clean.

  Here are some helpful resources:

  • Semantic HTML: MDN Web Docs on HTML elements
  • CSS Syntax Checking: W3C CSS Validation Service
  • Responsive Images: Using the picture element

  Keep up the great work! Each project you complete is a step forward in your development journey. Embrace the learning process and continue to challenge yourself. Your progress is impressive, and I can't wait to see what you create next!

  0
• 

  P

  David Inoa•150

  @davidinoaPosted 10 months ago

  Great work overall 👏

  Regarding your markup: using <a> tags with the href attribute set to an empty string (href="") is generally not recommended for several reasons:

  1. Usability and Accessibility: An empty href attribute can lead to confusion for users and can be problematic for accessibility. Users, especially those using assistive technologies, expect links to navigate them to a different page or section of the current page. An empty href can cause the link to do nothing or just reload the current page, which might not be the intended outcome and can be confusing.
  2. SEO Implications: From an SEO perspective, links with empty href attributes are essentially useless. Search engines like Google use links to discover new content and to understand the structure and hierarchy of a website. An empty href provides no value in this context and can be considered a poor practice.
  3. Better Alternatives Available: If the goal is to create a clickable element that triggers a JavaScript action, it's better to use a button (<button>) or to set the href attribute to a hash (#) or JavaScript void function (javascript:void(0);).

  0