Base Apparel Coming Soon Page

Community feedback

• 

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  Inside the FEM design files, their is a file labeled "active-states". This will display what needs to be active when the incorrect email is inputted.

  • The Alt Tag description in the logo needs to be improved upon. The description should state the company’s name.

  • The “image” serves no other purpose than to** be decorative**; it adds no value. Its Alt Tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.

  • You are currently using "built-in form validation" instead of JS to validate the users email input. Add invalidate to the form to prevent this.

  • For the hero image, you want to use the picture element to make the switches from mobile/desktop.

  • Your CSS code is extremely bloated with unnecessary code. Even though you implemented the grid yourself, you still installed all of Bootstrap's CSS.

  • Unless your company requires you to use a library , I strongly suggest you stay away from using libraries until you fully grasp the fundamentals of HTML, CSS and JS. By using a library, you are robbing yourself from actually learning how to code.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🍂🦃

  0