Design comparison
SolutionDesign
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- The logo’s
alt tag
description needs to be improved upon ⚠️; it should state the company’s name.
- Your
email input
, error content andbutton
needs to be wrapped inside aform
⚠️ and have a visibly hiddenlabel
attached to it for improved accessibility 📈.
More Info:📚
- Your
EventListener
⚠️ should be on theform
and it should be asubmit
not aclick
, since the user is submitting their email.
More Info:📚
Click vs. Submit EventListeners
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
Marked as helpful0 - The logo’s
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord