@ericsalvi
Posted
Hey @yterai,
This one looks incredible! Great job. I think Elaine mentioned everything I would have said. For the mobile-first approach, you don't need to declare 2 ranges for media queries. The way CSS cascades styles, it will naturally inherit the styles from additional larger min-width.
I couldn't see too many improvements but what I would like to see for future challenges is for you to work on your README.md file for the GitHub repository. Think of it as a way to explain yourself and what you worked on. Like a journal so others can read and discover new things.
Your JS was great as well. Works like charm. My only suggestion with this would be to include some type of something to know the email is correct and valid. So like on submit, maybe learn the input field and display an inline thank you message or something.
I cannot wait to see your next challenge and hopefully, you take a few of these recommendations from me and Elaine, it will really make your solutions pop!
Marked as helpful
@yterai
Posted
@ericsalvi Thank you for your feedback, Eric! I totally forgot to update my README.md file🫠 I'll work on it next time!
@ericsalvi
Posted
@yterai Just saw a typo that didn't make sense.
So like on submit, maybe clear the input field and display an inline thank you message or something
Marked as helpful