Base Apparel coming soon page - Going for PIXEL PERFECT?! :O

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted over 4 years ago

  Great work on this challenge, Pre! Your desktop layout looks great. As Shubham mentioned, it does break to the tablet layout slightly early. You could wait a little longer before switching, as there is still plenty of horizontal space in the browser to maintain the desktop layout.

  Keep up the great work!

  0

  ---

  

  Pre•160

  @predeyoPosted over 4 years ago

  @mattstuddert Thank you!

  0
• 

  Shubham Sharma•855

  @shubhamthedevPosted over 4 years ago

  Hi @predeyo, i think there is something wrong with your media queries since even on a laptop screen it seem to be in a tablet portrait form.

  0

  ---

  

  Pre•160

  @predeyoPosted over 4 years ago

  @tomboynotes Hey, thanks for the comment! What OS & Browser are you using? As there is some Css grid I have a support query that checks if browser supports it, else displays tabled form.

  Let me know and lets figure this thing out.

  0

  

  Shubham Sharma•855

  @shubhamthedevPosted over 4 years ago

  @predeyo I tried it in the latest version of chrome and Firefox, which support CSS grids out of the box.

  0

  

  Pre•160

  @predeyoPosted over 4 years ago

  @tomboynotes Hmm, that is a bit strange, I've just tested on Ubuntu(Firefox/Chrome) and Windows (Firefox/Chrome/Edge) and everything looks good. Could it be your screen resolution? Try turning on Responsive design mode in dev tools and set the width >1440px, lets see what happens. Also try direct link to demo: https://predeyo.github.io/base-apparel-coming-soon/

  0

  

  Shubham Sharma•855

  @shubhamthedevPosted over 4 years ago

  @predeyo Yes i checked and it works at 1440px but going anything less than that makes it look like it's in tablet portrait mode.

  0

  

  Pre•160

  @predeyoPosted over 4 years ago

  @tomboynotes Then It works as intended, thank you for testing. :)

  0