Base Apparel coming soon page

Community feedback

• 

  Mahesh Yadav•1,220

  @Mahesh-yadavPosted over 4 years ago

  I saw your code in github repo. You have written separate HTML markup for desktop and mobile designs. This is not a good practice. In responsive design, our html code is same for all screen sizes and through css we create layouts for different screen sizes.

  Currently your code has a lot of duplication, try to use single markup from next time.

  0
• 

  Abigail Colina•100

  @maenadPosted over 4 years ago

  Hey! Pretty good in my opinion!

  A couple of things I saw:

  MOBILE: *The input element looks a bit cramped.

  • The e-mail message does not appear.

  DEKTOP:

  • Image looks a bit too stretched, but I know the quality of the default's image is not the best.

  -- Overall is pretty good :D!

  0