Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Base Apparel coming soon page

Fabiola971 110

@Fabiola971

Desktop design screenshot for the Base Apparel coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello,

Can you look and give me, some feed-back to improve my javascript code !?

Thanks

Community feedback

Fabiola971 110

@Fabiola971

Posted

I don't understand why my picture isn't visible. Also, there is a default my button and the input but on the site, everything match

0

@devsotter

Posted

@Fabiola971 Hi, I'm not exactly sure why the image doesn't appear in the screenshot of your solution, but upon a quick look, I noticed that you placed the image inside a div and styled the parent div itself with a background using the image. I also noticed that there's a '@media only screen and (min-width: 1363px) .picture img { display: none; }' which makes the image disappear around 1440px, which is the breakpoint where the system takes a screenshot of your screen, I believe.

To resolve this, you should style only the 'img' tag and try removing the media query. If you don't want to refactor the code, I recommend simply replacing 'background-size: 100% 100%;' with 'background-size: cover;' so that the image doesn't get distorted in different sizes.

0
Fabiola971 110

@Fabiola971

Posted

@devsotter Hi, thanks for your response.

I just put the position of my container to position:relative, and "ta da" my picture appeared. I believe the picture disappear because I used absolute value in background-size: 100%.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord