Base-Apparel

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • Your EventListener should be on the form and it should be a submit not a click, since the user is submitting their email.

  More Info:📚

  Click vs. Submit EventListeners

  • When the user enters a valid email, I recommend adding some sort of confirmation stating that the email is valid to improve user experience.

  Here is an example of how it can look: Example

  • For improved accessibility 📈 for your content, it is best practice to use rem for your font-sizeand other property value. While em is best for media-queries. Using these units gives users the ability to scale elements up and down, relative to a set value.

  • The alt tag description in the logo needs to be improved upon. The description should state the company’s name.

  • Your CSS Reset is extremely bare and being underutilized. To fully maximize your CSS reset, you want to add more to it.

  Here are few CSS Resets that you can look at and use to create your own or just copy and paste one that is already prebuilt.

  Josh Comeau Reset

  Eric Meyer Reset

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  Marked as helpful

  1