Base Apparel coming soon page

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted almost 3 years ago

  👋 Hi Anna!

  🎉 Congratulations on finishing this challenge! I have some feedback on this solution:

  • Accessibility
    • Create a custom :focus-visible styling to any interactive elements (button, links, input, textarea). This will make the users can navigate this website using keyboard (by using Tab key) easily.
    • Alternative text for images should not contain any words that related to image, such as picture, logo, graphic, icon, etc. The user of assistive technology will know that it is either a logo or an icon the same as the normal user.
    • For the alternative text of the logo, you can write the company name as the alternative text of it.
    • Wrap the input element and the submit button with form element.
    • The button should have a `type="submit" attribute.
    • Use rem or sometimes em unit instead of px. Using px will not allow the users to control the size of the page based on their needs.
  • Styling
    • On mobile landscape view (640px * 360px), the hero image get cut off.
  • JavaScript
    • Separate the addEventListener with the function.
    • I would recommend making the form element listen for the submit event instead of the submit button listen for the click event.

  const submitEmail = (e) => {
    // some code
  }
  
  form.addEventListener("submit", submitEmail);
  

  That's it! Hopefully, this is helpful!

  0