Design comparison
Solution retrospective
Any feedback will be appreciated. Kindly give tips on how to optimize the responsiveness of the page. Thank you
Community feedback
- @zebokPosted over 3 years ago
Hey Jeffrey!
Check out the font size in desktop version. Also, you can change the font-family in the placeholder with ::placeholder pseudoelement. In your case would be:
#inputEmail::placeholder { } Check out more here: https://developer.mozilla.org/en-US/docs/Web/CSS/::placeholder
Another issue i have found in your version, is about the click. When i click the button, the error icon and the error message shows and dissapear. Check that.
And... (the last one).
Usually, the content never reaches the total width in desktop version. So, add some padding, margin, whatever you want. The idea is to leave a little space between the content and the screen border.
Thats all! Keep doing it! Keep practising! Some day, we will become experts :)
Marked as helpful1@jeffkobbyPosted over 3 years agoHey Sebastian!
Thanks to your feedback, I have made the necessary changes to my code. I also made sure to take care of the "blinking" error message by clearing the "setInterval" function I was testing in my Javascript but I have fixed that issue now.
I will also make sure to work on your last suggestion by finding the right values to make it visually appealing to other viewers.
Thank you very much!!!
0@zebokPosted over 3 years ago@jeffkobby
Hey! Now is looking much much better! Well done mate.
Like i said, keep going, keep practicing. I am learning as well, and there is no better way to learn than actually writing code.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord