Design comparison
SolutionDesign
Solution retrospective
happy for your feedback
Community feedback
- @Abdul400Posted almost 3 years ago
hello @Eman-AbdElZaher, Generally, your work looks really good and is very responsive. However, here are a few things I noticed.
- the link to your GitHub code does not work and there is no way of reviewing the code.
- I bypassed that by using the view page source in chrome web dev tools and noticed that you gave the hero-desktop image a width and height of 100% which squishes it when viewing devices with smaller width. I would recommend using the image as a background of the right-side and then positioning it accordingly using
background-position
. - The form placeholder should also be the same color as that of the paragraph. You can edit the placeholder using
::placeholder
property.
Other than that. Good Job!!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord