Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Base Apparel coming soon page with FLEXBOX, SASS, BEM and TypeScript.

GGSβ€’ 260

@Guilherme-Goncalves-de-Souza

Desktop design screenshot for the Base Apparel coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello! I'm learning how to use the css BEM, so what did you think of my BEM css and how can I improve?

πŸ‡§πŸ‡· Deixe aqui seu feedback ou sua crΓ­tica construtiva!!!

en Leave your feedback or constructive criticism here!!!

Community feedback

T
ApplePieGiraffeβ€’ 30,545

@ApplePieGiraffe

Posted

Hello there, GGS! πŸ‘‹

Good job on this challenge! πŸ‘ Your HTML looks good and so does your use of BEM! πŸ‘

One thing I'd like to suggest is to make sure to add aria-hidden="true" to any hidden text that also shouldn't be read by screen readers (such as the form field error message when it is not shown).

Also, be careful not to add alt text to images that don't need to be noticed by screen readers (such as icon images in many cases). Leaving the alt attribute blank for those images will ensure that screen readers skip over them and do not bother to read them if they are not necessary/important. Just a tip! πŸ˜‰

Hope you find these suggestions helpful. 😊

Keep coding (and happy coding, too)! 😁

Marked as helpful

1

GGSβ€’ 260

@Guilherme-Goncalves-de-Souza

Posted

Thank you very much for all the tips, are very important tips and that I will definitely use in my projects.

Thank you very much @ApplePieGiraffe!!!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord