Base Apparel coming soon page #22

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted about 2 years ago

  Hello there! 👋

  Congratulations on finishing this challenge! 🎉

  For me, I tried to find the Regular Expression on the internet first. Then, try improving the existing RegEx until it works the way I wanted. I recommend using RegExr to help you write your own RegEx or improve the existing RegEx. It can also be used to understand the RegEx that you get from the internet.

  Some more suggestions from me.

  • The alternative text for the logo should not be "logo". It should tell the name of the company.
  • For the media attribute, I recommend choosing either to use max-width or min-width. If you choose to use min-width then only the desktop image needs the media attribute.
  • Input element must have a label. I recommend using aria-label to give a label to the input element.
  • The submit button needs a good label. Currently, the submit button is pronounced as "icon-arrow, button" by screen readers. So, I recommend changing the alternative text to something like "Sign Up" or "Join the wait list".

  I recommend visiting the Solid Start website to give you an overview of web accessibility.

  I hope this helps! Happy coding!

  Marked as helpful

  1

  ---

  

  DefinitelyObsessed•440

  @DefinitelyObsessedPosted about 2 years ago

  Thank you so much, @vanzasetia . :)

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted about 2 years ago

  @DefinitelyObsessed You are welcome! 👍

  Marked as helpful

  0