Base apparel coming soon landing page

Community feedback

• 

  Carlos•1,110

  @Carlos-A-PPosted about 3 years ago

  Hello, the input works great. A few things that I noticed:

  • in mobile view, you reduced the width of left-div-child to 60%, id suggests keeping it at 100% and maybe adding width to the content below so that the image stays responsive.
  • in desktop view, the image doesn't seem too be responsive so something you can add to your .right-div is width: 100%; and max-width: 700px;. These two will hold the image size as the screen gets wider.
  • I also added background-position: right 60% top 0; which will change the position of the desktop image as the screen gets shorter so that you can still see the person's face. It'll all look like this together:

  .right-div {
      width: 100%;
      max-width: 700px;
      height: 100%;
      background-image: url(images/hero-desktop.jpg);
      background-repeat: no-repeat;
      background-position: right 60% top 0;
      background-size: cover;
      background-color: green;
  }
  

  Marked as helpful

  1

  ---

  

  Gaurav Kumar•570

  @GauravkumarioPosted about 3 years ago

  @Carlos-A-P I will add your solution in my code thank you for suggestion.

  0