Request path contains unescaped characters
Request path contains unescaped characters
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Base apparel coming soon landing page

@Gauravkumario

Desktop design screenshot for the Base Apparel coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Do check my new project if you caught any bug please mention in comment . feedback and suggestions are welcomed.

Community feedback

Carlos 1,110

@Carlos-A-P

Posted

Hello, the input works great. A few things that I noticed:

  • in mobile view, you reduced the width of left-div-child to 60%, id suggests keeping it at 100% and maybe adding width to the content below so that the image stays responsive.
  • in desktop view, the image doesn't seem too be responsive so something you can add to your .right-div is width: 100%; and max-width: 700px;. These two will hold the image size as the screen gets wider.
  • I also added background-position: right 60% top 0; which will change the position of the desktop image as the screen gets shorter so that you can still see the person's face. It'll all look like this together:
.right-div {
    width: 100%;
    max-width: 700px;
    height: 100%;
    background-image: url(images/hero-desktop.jpg);
    background-repeat: no-repeat;
    background-position: right 60% top 0;
    background-size: cover;
    background-color: green;
}

Marked as helpful

1

@Gauravkumario

Posted

@Carlos-A-P I will add your solution in my code thank you for suggestion.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord