Base Apparel Coming Soon

Community feedback

• 

  James Le-Goff•310

  @jameslegoff92Posted about 2 years ago

  Hi there Roxanne,

  Excellent work on this project. I would just like to point out a few things.

  1. When the screen size is less than 375px, your image disappears because of the min-width you set for it. This is the piece of code responsible for it: <source media="(min-width: 375px)" srcset="images/hero-mobile.jpg 375w">.

  2. Between the screen sizes 862px and 1049px the design breaks.

  3. At larger screen sizes (greater than 1500px), the text content is no longer vertically centered.

  Responsive design is almost a must in the industry these days, so our designs need to look good on most screen sizes. I challenge you to fix these edge cases. What you'll learn, will become invaluable. Especially, once your start building multi-page websites, with multiple components. If you need help, you can always send me a message😊

  Happy Coding!

  Marked as helpful

  0

  ---

  

  Roxanne•260

  @rox-stahlPosted about 2 years ago

  @jameslegoff92 I would most definitely like help with this. I feel like this part of my learning is lacking and there are so many explanations. Thank you in advance for your help!

  0

  

  Roxanne•260

  @rox-stahlPosted about 2 years ago

  @jameslegoff92 I DID IT!!!!

  1

  

  James Le-Goff•310

  @jameslegoff92Posted about 2 years ago

  @rox-stahl No problem. It will be a lot quicker for me to respond to any questions you might have if you add me on twitter. My username is @jameslegoff. Feel free to make a list of a few questions you have and I'll do my best to give you a thorough answer that will hopefully help propel you forward in your coding journey. 😊

  0