Skip to content
Submitted almost 3 years ago

Base Apparel Challenge with HTML, Sass (BEM) and JS

Gloria Ataa Sekyere•290
@GloriaSekyere
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Base Apparel coming soon page
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

In a real situation, I'm not sure if my form will be submitted based on my JavaScript code. Can you go through it and give me some feedback? I have a lot to learn about forms.

Community feedback

  • LiBee•370
    @Li-BeePosted almost 3 years ago

    Really like this and well done on getting it close to the design. 👏 You have an accessibility issue you need to fix - to ensure that scaling works properly on different devices i believe.

    Marked as helpful
    1
  • Fraser Watt•1,790
    @fraserwatPosted almost 3 years ago

    Hey Gloria! Form validation seems to work ok for me! You'd have the actual submission in the <form> html, but that's beyond what this challenge is asking.

    One thing I would change about it though is have the validation-text be set to default as display: none instead of visibility: 0. This way, its appearance on the screen will be shown by screen readers.

    Would improve this by thinking semantically (good for SEO and accessibility) - for example what I mean by this. your <div class="logo"> element could be a <header>, etc.

    Keep it up!

    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord