Base Apparel | BEM

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Greetings, Vincent Frank! 👋

  Nice work on this challenge! 🙌 Your solution is responsive and the form validation works well! 👍

  I suggest,

  • Labeling the input and button element in some way (as your solution report suggests) in order to identify them and make your solution more accessible.
  • Adding overflow-x: hidden to the body to prevent a horizontal scroll bar from appearing along the bottom of the screen at certain screen widths.
  • Making sure the heading and the paragraph below it do not cover up the logo when the height of the screen decreases in the desktop layout.
  • Adding a max-width to the input element to prevent it from becoming too wide on extra-large screens.

  Hope those tips help. 🙂

  Keep coding (and happy coding, too)! 😁

  2