Bad Landing Page (feel free to roast me, feedback is also appreciated)
Design comparison
Solution retrospective
please feel free to roast me, and feedback is appreciated. could've redone the codes but decided against it
i also don't know github yet... don't know how to use a repository
Community feedback
- @AgataLiberskaPosted over 3 years ago
Hi @Duhli! This is really well done for your first challenge!
One thing I noticed is that the card is too wide for some screen widths (you can view that in your browser in dev tools). You could set the width using % or vw units and then just set a max-width so it doesn't stretch too much.
Also, have a look at the report here - your
<img>
elements are missing thealt
attribute. If the images are purely decorative, just add an empty alt:alt=""
, but don't omit it completely.Hope this helps!
1 - @JohndiddlesPosted over 3 years ago
nice.
I don't know much myself but I can help with some tips on github and github pages
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord