Design comparison
Solution retrospective
Hi there! 😀
This is my solution for the Advice Generator App. This app generates Advice and change the backgroud color when you click to the button generate.
Any feedback and advice are welcome!
Happy coding 😁
Community feedback
- @tltd0807Posted about 2 years ago
hi Deniel Den, congratulation on your challenge, Your app doesn't work properly on firefox To fix that you can try: https://stackoverflow.com/questions/71255840/fetch-api-return-same-data-always/71256248#71256248
Marked as helpful2@denieldenPosted about 2 years ago@tltd0807 Thank you!
I also use firefox and as you can see in the stackoverflow ticket it is due to a "bug" of too close requests.
Anyway thanks, it was helpful :)
0 - @john-miragePosted about 2 years ago
Hello, nice work on the animations and the idea of the changing background.
I used animations too, it was really fun. You can check my project here.
Some suggestions:
- The user is allowed to spam the button which cause the animation to interupt abruptly. It may be better to prevent the user to click if:
- The api has not responded yet
- The animation is not finished.
- The card height is not animated, maybe it may be better to see the card heigh animate when the new advice is taller or smaller than the previous one.
Marked as helpful1@denieldenPosted about 2 years ago@john-mirage I looked at your solution, you did a great job with animations, congratulations :)
And thanks for you comment!
0 - The user is allowed to spam the button which cause the animation to interupt abruptly. It may be better to prevent the user to click if:
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord