Design comparison
Solution retrospective
Any feedback is welcome, please feel free to suggest anything.
is it ok to use "em" and "rem" values for margin and padding? Or should those values only be used for fonts? because I was using "%" to set some values but was not sure what is best.
I had a lot of difficulty with the social media icons. The borders around them are different sizes for each icon, I can't get them all to look the same.
Community feedback
- @ndroPosted over 2 years ago
Hi, 👏 congrats for completing the challenge
I think it's ok to use
rem
orem
. Some people usepx
for 1px or little size, then userem
for rest. Consistency is better.For social media icons, you can try to use an SVG tag and then edit the style for
width
andheight
. Font-awesome provides it.<svg xmlns="http://www.w3.org/2000/svg" style="width: 16px; height: 16px" viewBox="0 0 320 512" fill="currentColor"> </svg>
Everything is nice! 🤘
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord