Html, Css

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  Hi Piyawat5, I took some time to look at your solution and you did a great job!

  Also I have some tips for improving your code:

  • add main tag and wrap the card for Accessibility
  • To make it look as close to the design as possible change padding:1.5rem; and border-radius: 1.2rem; to box class
  • remove all margin from box
  • try to use flexbox to the body for center the card. Read here -> best flex guide
  • after add min-heigth: 100vh to body because Flexbox aligns to the size of the parent container
  • instead of using px try to use relative units of measurement -> read here

  Overall you did well :)

  Hope this help and happy coding!

  Marked as helpful

  2

  ---

  

  piyawat5•90

  @piyawat5Posted almost 3 years ago

  @denielden I fixed it. Thank you for your advice :)

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  @piyawat5 You are welcome! Now it's much better. I would really appreciate if you mark my comment as helpful if it helped you, thank you very much :)

  0
• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  Hay ! piyawat5 Good Job on challenge

  These below mentioned tricks will help you remove any Accessibility Issues

  -> Add Main tag after body <main class="container"></main>

  -> Learn more on accessibility issues

  If this comment helps you then pls mark it as helpful!

  Have a good day and keep coding 👍!

  Marked as helpful

  1

  ---

  

  piyawat5•90

  @piyawat5Posted almost 3 years ago

  @Crazimonk Thank you :)

  1
• 

  Hexer•3,660

  @EmmanuelHexerPosted almost 3 years ago

  Great work overall man.

  Marked as helpful

  1

  ---

  

  piyawat5•90

  @piyawat5Posted almost 3 years ago

  @Phalcin Thank you:)

  0