Design comparison
Solution retrospective
I continued to apply the same methodologies as on previous projects, mobile first, use of the BEM method which I think this time the class names are explicit, annotate my code to explain what is happening there and I first finished the mobile tablet and desktop design before adding the small javascript functions.
What challenges did you encounter, and how did you overcome them?In the tablet version the pop-up menu was out of the box so I improvised an intermediate version with a menu to the left of the button and an arrow to the right. The most complicated thing I think was the small details, changing the color of the arrow in the button, I improvised a solution with css filters, but there might have been simpler options.
What specific areas of your project would you like help with?All advice is welcome whether in html, css or javascript, I would be curious to know the opinion of people with more advanced levels than mine on the way I organized my code, there are surely methodologies which I don't know yet, thank you in advance to those who will take the time to read my code, it's really a big help when you're self-taught
Community feedback
- @muiruri3000Posted about 2 months ago
Hi, Good Job, Keep it up. ##CSS Reset. Just a small issue to note it is important to set all paddings and margins zero so that you can be able to have uniform spacing as you set them yourselves. border box also helps so that you do not have to manually subtract the values of borders and paddings. all this is done just by
,::before,::after{ margin:0; padding:0; box-sizing: border-box; }
Marked as helpful1@TomSifPosted about 2 months ago@muiruri3000
Hello :) Thanks for taking the time to take a detailed look at the code, thanks for this tip, great I will apply your advice on the next project. This is exactly the kind of cool little comment that will help me improve. Thanks again :)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord