Frontend Mentor | Article-preview-component-master coding challenge solution

Solution retrospective

This is my solution to the Article-preview-component-master challenge.

The share button is placed at the edge of the main container, I think it looks better there.

Things you can help me with

Do check out my code and feel free to leave any comments that can improve my code.🤞🤞

Community feedback

@0xabdulkhaliq

Posted over 1 year ago

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

I have other recommendations regarding your code that I believe will be of great interest to you.

BODY MEASUREMENTS 📐:

Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens, such as mobile devices in landscape orientation

For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.

But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

@magname

Posted over 1 year ago

@0xAbdulKhalid Thanks for the review. Updated the code.

Article-preview-component-master