Article-preview-component-challenge-hub

Community feedback

• 

  Lorenzo Franco•480

  @LfrancosPosted almost 3 years ago

  Hello Luka!

  This is looking good! I can see that your report says that you have no problems, that is really good. Mine told me that I had one accessibility problem I need to fix that. I need to get in to the habit of of making sure that I'm not making any mistakes there.

  The thing that I would encourage you to take more time is that you look if your website is working in responsive mode. I can see that they work pretty good in the resolutions that they provide, but if you play around with the size of the screen you will see that at certain points it brakes. The way that I've been approaching this is by working mobile first and I think it is really helpful for responsiveness.

  One thing that I would do in your code is to add a min-width to the div that is below the main element. that way you can make sure that the height does not stretches as much as it is doing here.

  But the thing that is making your responsiveness not to work is that you are adding a margin of -1.5rem to the "footer-flex" I would encourage you to make sure that you don't use negative numbers in there since that will make other elements go on top of that.

  Hopefully this helps : )

  Marked as helpful

  2

  ---

  

  Luka•320

  @lukakavtarraPosted almost 3 years ago

  @Lfrancos thanks for your help it really helped me to solve some of my major problems 😍😍

  I've looked up in your code and attribute(footer) class should be contained by landmark ( you should add <footer> tag or you should include attribute class in main tag) that should solve your problem

  thanks for your help man :) really appreciate it

  1