Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Article-Preview-Component (HTML, CSS and JavaScript Vanilla)

Hรฉlioโ€ข 190

@helio020

Desktop design screenshot for the Article preview component coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

_nehal๐Ÿ’Žโ€ข 6,710

@NehalSahu8055

Posted

Hello Coder ๐Ÿ‘‹.

Congratulations on successfully completing the challenge! ๐ŸŽ‰

Few suggestions regarding design.

  • To proper align the image as per fem design. Add:
.article__img {
object-fit: cover;
object-position: left;
}

  • Use some meaningful and descriptive alt for non decorative image like Drawer with some decorative items above it.

I hope you find this helpful.

Happy coding๐Ÿ˜„

Marked as helpful

0
Abdul Khaliq ๐Ÿš€โ€ข 72,660

@0xabdulkhaliq

Posted

Hello there ๐Ÿ‘‹. Congratulations on successfully completing the challenge! ๐ŸŽ‰

  • I have other recommendations regarding your code that I believe will be of great interest to you.

BODY MEASUREMENTS ๐Ÿ“:

  • The width: 100vw property for body element is not necessary. because it's a block level element which will take the full width of the page by default.
  • Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens, such as mobile devices in landscape orientation.
  • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.
  • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

.

I hope you find this helpful ๐Ÿ˜„ Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord