Design comparison
Solution retrospective
Hey! I finished another great project. This project test my understand of positioning and stacking context. Look like simple but I spend most of the time write CSS. But Javascript part is simple :). I also learned the trick to make triangle part of popup using pseudo element. So happy to finish it. I think it looks good 😊. What do you guys think about it? I'm really appreciated any feedbacks. Happy coding!
Community feedback
- @techantherePosted almost 3 years ago
Great job, the solution looks so good. Just a few things that are worth mentioning, the share button should be an interactive element and div is not an interactive element instead a link or button is used for this purpose. So here the share img should be enclosed by the button. Also there is no way for a screen reader to know if the popup is currently expanded or collapsed, and this is not good from accessibility point of view as well. You should add a way to tell the user if a button is epxanded or not and aria-expanded can be used for this purpose. Then an aria-controls on the button along with aria-labelledby set to the id of the popup will be helpful to let the user know if the share options are active or not. Other than that all fine.
Marked as helpful1@chrisvn188Posted almost 3 years ago@techanthere Thank you so much for the feedback. This is what I really need and appreciated. I'm currently learn about accessibility, just scratching the surface :). I need to learn more and improve. Do you have any good resources to learn about accessibility?. Thanks in advance!
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord