Article-preview-component

Community feedback

• 

  Shahin NJ•1,190

  @SJ-NosratPosted over 2 years ago

  Hey Alexander, Great job! I found this particular project quite challenging myself.

  I was just wondering why don't you take full use of Flexbox; I see you added the display: flex; property on your <div class="container"> tag, however, I don't see justify-content: center; and align-items: center; properties; this will center your card properly.

  Although it does break card on the mobile-view. I suggest approaching every project with a mobile-first approach and then adding the appropriate @media queries for larger viewport sizes (screen sizes). You can find more about the approach on the YouTube video by Kevin Powell.

  Best of luck on your coding journey! You're doing great!

  Marked as helpful

  0
• 

  Caio de Alcantara Santos•250

  @caio-alcantaraPosted over 2 years ago

  Hey, Alexander, great work! I'd say you just need to add some padding and adjust the font-size. And also, to fix these accessibility issues, you'll have to wrap all the body content into the tag <main>, and set an 'alt' text to every image. Cheers :)

  Marked as helpful

  0

  ---

  

  Alexander•80

  @AlexanderWiklowPosted over 2 years ago

  @caio-alcantara thank you for your feedback!:)

  0
• 

  Alexander•80

  @AlexanderWiklowPosted over 2 years ago

  thanks man! i will watch the video and make a note for myself to use the flexbox more/correct:)

  0