Article-Preview

Community feedback

• 

  Maximilian Dybvik•200

  @RegexRiddlerPosted 6 months ago

  Good work completing this challenge! 😁

  The reason you are having trouble with your social media sharing menu is because you have nested it inside the wrapper for the author information.

  This is your code.

  // Author information wrapper
  <div class="profileBox">
      <div id="profileImg">...</div>
      <div id="profileContent">...</div>
      <div id="shareIcon">...</div>
  
      // Social media sharing menu
      <div class="notification">
          <span>SHARE</span>
          <img src="./images/icon-facebook.svg"/>
          <img src="./images/icon-twitter.svg" alt="">
          <img src="./images/icon-pinterest.svg"/>
      </div>
  </div>
  

  What I suggest you do instead is to move the "notification" div outside of the "profileBox" div, directly below it and use CSS position attribute to properly place the element.

  Like this.

  // Author information wrapper
  <div class="profileBox">
      <div id="profileImg">...</div>
      <div id="profileContent">...</div>
      <div id="shareIcon">...</div>
  </div>
  
  // Social media sharing menu
  <div class="notification">...</div>
  

  Here is my submission, and my GitHub repo if you feel like comparing code.

  0

  ---

  

  mrriyas•60

  @mrriyasPosted 6 months ago

  Thanks @RegexRiddler, will take your suggestion and change it corrodingly, could you please assist me further?

  0

  

  Maximilian Dybvik•200

  @RegexRiddlerPosted 6 months ago

  Sure! @mrriyas, first make your changes and push them to your GitHub repo, then just leave a comment on what you would like feedback on 👍

  0