Article | preview-component

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Greetings, Mo'men Ashraf! 👋

  Good effort on this challenge! 👍 You have created a nice transition effect for the share button. 👏

  Some suggestions from me.

  • Each social media icon should be wrapped by an anchor tag. Each of them is actually a social media link.
  • As you may notice in the design comparison, some of the elements inside the card are overflowing. It happens because there's a specific height for the card element. I would recommend removing the height. Let the content inside it controls the height of it. This way, the card is more responsive and no overflowing issue will happen.
  • On mobile landscape, to be specific 640px * 375px, the card is so wide. So, my recommendation is to have a max-width to prevent the card from always filling the entire page.

  That's it! Hope you find this useful! 😁

  Marked as helpful

  1

  ---

  

  Mo'men Ashraf•340

  @Moamen31Posted over 2 years ago

  @vanzasetia thank you so much this was very helpful not just in this challenge but for me too. I will fix them as soon as I can.

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  @Moamen31 You're welcome! 👍

  0