@vanzasetia
Posted
Greetings, Mo'men Ashraf! š
Good effort on this challenge! š You have created a nice transition effect for the share button. š
Some suggestions from me.
- Each social media icon should be wrapped by an anchor tag. Each of them is actually a social media link.
- As you may notice in the design comparison, some of the elements inside the card are overflowing. It happens because there's a specific height for the card element. I would recommend removing the
height
. Let the content inside it controls the height of it. This way, the card is more responsive and no overflowing issue will happen. - On mobile landscape, to be specific
640px
*375px
, the card is so wide. So, my recommendation is to have amax-width
to prevent the card from always filling the entire page.
That's it! Hope you find this useful! š
Marked as helpful
@Moamen31
Posted
@vanzasetia thank you so much this was very helpful not just in this challenge but for me too. I will fix them as soon as I can.
@vanzasetia
Posted
@Moamen31 You're welcome! š