Article preview with Social media popup

Community feedback

• 

  Adeola Ganiu•1,320

  @DeolabestPosted over 1 year ago

  https://www.youtube.com/watch?v=BW0FCFV323s

  Hey @Kuraanal, Congratulations on completing this challenge!

  Here is my feedback:

  • Firstly, you did not upload your project properly on Github. Please watch this video for guidance https://www.youtube.com/watch?v=BW0FCFV323s

  • It's not a good practice to use px to set font-size. Instead use rem units, they are great since they adapt better to the font-size the user will set in the browser settings. You can convert from px to rem here: https://pixelsconverter.com/px-to-rem.

  • The project is not responsive enough. The width of the main element should determine where the media query should begin.

  Keep doing a good job!

  0