Design comparison
Solution retrospective
Am happy to learn from your feedback, so if you can please help me to improve myself. Thank You.
Community feedback
- @SuleeymanPosted over 3 years ago
First of all, you don't need to toggle the icon-share on your js script.
Also, don't use div tag, when you can use semantic tags like header, nav, section, main, footer,... (they are all display: block) It's better for SEO, read more about it: https://www.freecodecamp.org/news/semantic-html5-elements/
Your media querie is a mistake: @media screen and (max-width: 1500px){ .container { width: 95% } }
max-width: 1500px means this interval [1500px; 0px]. Then your container destroy the image and the layout.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord