Great work on this project! Here are a few suggestions for improvements:
- The share button is not fully functional on mobile. You can make the popup visible, but it's impossible to hide it again due to the share button being hidden.
HTML
-
"Drawers" is not a sufficient alt text for the image. Try to describe it a bit more.
-
The share button must be inside a
<button>
element. This will make the JavaScript easier as well. -
I don't understand why you have added a "Share-2" icon. This is not needed.
CSS
-
The share button does not change color when it's clicked. Look at the design to see how it's supposed to look.
-
You have used rem units for the font, but why not the container and margin/padding. The text overflows the container when it's increased.
-
Use rem or em for the media queries.
Marked as helpful
@hangtime319
Posted
@moadavou Thank you very much! I will follow your tips and make the changes