article preview, scss, js, bem

Community feedback

• 

  Rio Cantre•9,690

  @RioCantrePosted almost 3 years ago

  Hello there! Awesome job with this one. Viewing your solution, I would suggest the following for you...

  • Adjust the padding in the .article rule set into padding: 1rem 3rem;
  • Adjust the properties in the .writter into this ...

  .writter {
    max-width: 15rem;
    grid-area: writter;
    display: grid;
    grid-template-areas: "avatar name" "avatar artcl-date";
    column-gap: 1rem;
    justify-self: start;
    align-self: center;
  }
  

  • Import the attribution style in the CSS file and remove the style tag

  Hope this helps and Keep up the good work!

  Marked as helpful

  1

  ---

  

  BasemAmr•120

  @BasemAmrPosted almost 3 years ago

  Thank you for the feedback, @RioCantre ! for the .witter div, I aligned it to end so it doesn't change its vertical position, which can lead on some devices to appear over the .share__links div

  and yeah it was really annoying so I set a maximum width for the .card main element so its shape still good

  alright, I've actually imported attribution style in the main scss file but forgot to delete its styling from index.html

  thanks again, happy coding :)

  1